-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentryJobErrorReportingClient: set event platform from parsed stacktrace #16906
Conversation
public static final String ERROR_MAP_MESSAGE_KEY = "errorMessage"; | ||
public static final String ERROR_MAP_TYPE_KEY = "errorType"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not being used
@@ -23,10 +23,9 @@ | |||
@SuppressWarnings("PMD.AvoidLiteralsInIfCondition") | |||
public class SentryExceptionHelper { | |||
|
|||
private static final Logger LOGGER = LoggerFactory.getLogger(SentryExceptionHelper.class); | |||
public record SentryParsedException(String platform, List<SentryException> exceptions) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an enum of the platforms is more appropriate here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 done in 85cbf67
…ace (airbytehq#16906) * set sentry event platform from parsed stacktrace * fix pmd * use an enum * use enum in test * fix imports * fix imports * format * fix imports
…ace (airbytehq#16906) * set sentry event platform from parsed stacktrace * fix pmd * use an enum * use enum in test * fix imports * fix imports * format * fix imports
What
Set sentry's
platform
on events for better display and so we can use it to determine who should be paged.From the Sentry docs https://develop.sentry.dev/sdk/event-payloads/#required-attributes:
So dbt errors will still be sent as
other
close https://github.com/airbytehq/airbyte-cloud/issues/2650
How
SentryParsedException
class from the exception parser that includes the platform.SentryParsedException
's platform to set it on the event and add a tag